Fix crash in AppNotifyChannelSetup when incognito profiles are used.

chrome/browser/extensions/api/app/app_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app/app_api.h"
 
 #include "base/values.h"
 #include "base/time.h"
 #include "chrome/browser/extensions/app_notification_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/notification_service.h"
 
 const char kBodyTextKey[] = "bodyText";
 const char kExtensionIdKey[] = "extensionId";
 const char kLinkTextKey[] = "linkText";
 const char kLinkUrlKey[] = "linkUrl";
 const char kTitleKey[] = "title";
 
 const char kInvalidExtensionIdError[] =
     "Invalid extension id";
 const char kMissingLinkTextError[] =
     "You must specify linkText if you use linkUrl";
+const char kIncognitoError[] =
+    "This API is not accessible by 'split' mode "
+    "extensions in incognito windows.";
 
 bool AppNotifyFunction::RunImpl() {
+  if (!include_incognito() && profile_->IsOffTheRecord()) {

[Mihai Parparita -not on Chrome, 2012/03/22 19:44:20]

There are actually two app notification APIs:
1) The (experimental) extension API, which allows an extension to display
notifications on behalf of an app (this was added mainly for the sake of
testing/prototyping)
2) The chrome.appNotifications.getChannel, which is what apps actually use. The
incognito check would need to happen in AppBindings::GetAppNotifyChannel and/or
in ExtensionTabHelper::OnGetAppNotifyChannel.

[jstritar, 2012/03/22 20:21:10]

Oh yeah, done. Do you know why this needs such custom bindings?

[asargent_no_longer_on_chrome, 2012/03/22 20:58:11]

Because it's exposed to hosted apps, which the regular extensions bindings
aren't.

[jstritar, 2012/03/23 15:31:43]

Thanks for the explanation! We might be able to get rid of the custom binding
soon then, with the work kalman and aa have been doing.

+    error_ = kIncognitoError;
+    return false;
+  }
+
   DictionaryValue* details;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
   EXTENSION_FUNCTION_VALIDATE(details != NULL);
 
   // TODO(asargent) remove this before the API leaves experimental.
   std::string id = extension_id();
   if (details->HasKey(kExtensionIdKey)) {
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kExtensionIdKey, &id));
     if (!profile()->GetExtensionService()->GetExtensionById(id, true)) {
       error_ = kInvalidExtensionIdError;
@@ skipping 32 matching lines @@
 
   AppNotificationManager* manager =
       profile()->GetExtensionService()->app_notification_manager();
 
   manager->Add(item.release());
 
   return true;
 }
 
 bool AppClearAllNotificationsFunction::RunImpl() {
+  if (!include_incognito() && profile_->IsOffTheRecord()) {
+    error_ = kIncognitoError;
+    return false;
+  }
+
   std::string id = extension_id();
   DictionaryValue* details = NULL;
   if (args_->GetDictionary(0, &details) && details->HasKey(kExtensionIdKey)) {
     EXTENSION_FUNCTION_VALIDATE(details->GetString(kExtensionIdKey, &id));
     if (!profile()->GetExtensionService()->GetExtensionById(id, true)) {
       error_ = kInvalidExtensionIdError;
       return false;
     }
   }
 
   AppNotificationManager* manager =
       profile()->GetExtensionService()->app_notification_manager();
   manager->ClearAll(id);
   return true;
 }