Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 9730021: Remove experimental sync promo layouts (Closed)

Created:
8 years, 9 months ago by sail
Modified:
8 years, 9 months ago
Reviewers:
sky, Dan Beam
CC:
chromium-reviews
Visibility:
Public.

Description

Remove experimental sync promo layouts We added four experimental sync promo layouts for M18. The experiment is now over and we've decided to use layout 3 (simple version). This CL removes the experimental layouts from the C++ code. I'll send out a second CL to remove the DOM UI code. BUG=119014 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127813

Patch Set 1 #

Patch Set 2 : a #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -690 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_init.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 8 chunks +9 lines, -73 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo/sync_promo_dialog.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo/sync_promo_dialog.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo/sync_promo_dialog_browsertest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 chunk +2 lines, -20 lines 1 comment Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler2.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler2.cc View 1 chunk +2 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_trial.h View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc View 1 1 chunk +2 lines, -198 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.h View 3 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 3 chunks +1 line, -39 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
8 years, 9 months ago (2012-03-20 00:34:16 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-20 00:44:39 UTC) #2
Dan Beam
http://codereview.chromium.org/9730021/diff/1017/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc File chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc (right): http://codereview.chromium.org/9730021/diff/1017/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc#newcode205 chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc:205: // TODO(sail): The version argument is going away, remove ...
8 years, 9 months ago (2012-03-20 03:35:09 UTC) #3
sail
> when is a better time to do this than now? http://codereview.chromium.org/9741001/
8 years, 9 months ago (2012-03-20 19:42:18 UTC) #4
Dan Beam
lgtm
8 years, 9 months ago (2012-03-20 20:45:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9730021/1017
8 years, 9 months ago (2012-03-20 21:11:28 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 22:22:25 UTC) #7
Change committed as 127813

Powered by Google App Engine
This is Rietveld 408576698