Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4377)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

Issue 9730021: Remove experimental sync promo layouts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
index ac9ae86fc1c2390ff588f2ae968e3eaec393112a..cbe9ec6c23da883e419f577c7346b1af7192f0bc 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
@@ -201,27 +201,9 @@ void SyncPromoHandler::HandleCloseSyncPromo(const base::ListValue* args) {
}
}
-int SyncPromoHandler::GetPromoVersion() {
- switch (SyncPromoUI::GetSyncPromoVersion()) {
- case SyncPromoUI::VERSION_DEFAULT:
- return 0;
- case SyncPromoUI::VERSION_DEVICES:
- return 1;
- case SyncPromoUI::VERSION_VERBOSE:
- return 2;
- case SyncPromoUI::VERSION_SIMPLE:
- return 3;
- case SyncPromoUI::VERSION_DIALOG:
- // Use the simple sync promo layout for the dialog version.
- return 3;
- default:
- NOTREACHED();
- return 0;
- }
-}
-
void SyncPromoHandler::HandleInitializeSyncPromo(const base::ListValue* args) {
- base::FundamentalValue version(GetPromoVersion());
+ // TODO(sail): The version argument is going away, remove this.
Dan Beam 2012/03/20 03:35:10 when is a better time to do this than now?
+ base::FundamentalValue version(3);
web_ui()->CallJavascriptFunction("SyncSetupOverlay.showPromoVersion",
version);
« no previous file with comments | « chrome/browser/ui/webui/sync_promo/sync_promo_handler.h ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_handler2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698