Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 9729015: Compute immediate dominators using SEMI-NCA. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)
Modified:
8 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Compute immediate dominators using SEMI-NCA. This is a version of the Lengauer-Tarjan algorithm that is both simpler and faster. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5737

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -16 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +89 lines, -1 line 1 comment Download
M runtime/vm/intermediate_language.h View 8 chunks +28 lines, -7 lines 1 comment Download
M runtime/vm/intermediate_language.cc View 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
Dominators computation is unverified. I'd like to have tests that verify it. We could verify ...
8 years, 9 months ago (2012-03-19 23:24:59 UTC) #1
srdjan
8 years, 9 months ago (2012-03-21 20:57:50 UTC) #2
LGTM, make sure you run all frog code as test. 
Questions raised and plans proposed were discussed offline.

http://codereview.chromium.org/9729015/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

http://codereview.chromium.org/9729015/diff/1/runtime/vm/flow_graph_builder.c...
runtime/vm/flow_graph_builder.cc:1707: intptr_t size = parent->length();
const intptr_t

Powered by Google App Engine
This is Rietveld 408576698