Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 9716018: mac: Update signature of ShowOneClickSigninDialog() to match declaration. (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
CC:
chromium-reviews, akalin
Visibility:
Public.

Description

mac: Update signature of ShowOneClickSigninDialog() to match declaration. The declaration was changed in http://codereview.chromium.org/9592015, but the mac implementation wasn't updated. BUG=117015, 90078 TEST=Add -all_load to the linker flags. __Z24ShowOneClickSigninDialogP7ProfileRKSsS2_S2_ doesn't show up in the missing symbols list. TBR=rogerta Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/one_click_signin_dialog_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
This currently happens to work because ld doesn't load .o files from static libraries if ...
8 years, 9 months ago (2012-03-17 20:20:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9716018/1
8 years, 9 months ago (2012-03-17 20:20:58 UTC) #2
commit-bot: I haz the power
Change committed as 127382
8 years, 9 months ago (2012-03-17 22:43:02 UTC) #3
Roger Tawa OOO till Jul 10th
8 years, 9 months ago (2012-03-19 15:04:00 UTC) #4
lgtm

Thanks Nico!  Fred will be working in the Mac UI shortly and was going to
address this at that time.

Powered by Google App Engine
This is Rietveld 408576698