Added multi-login support to one-click signin.

Added multi-login support to one-click signin.

BUG=117015
TEST=See bug description for details repro steps and expected behaviour.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125327

[Roger Tawa OOO till Jul 10th, 2012-03-06 20:20:44]

Hi Drew,

please review.

Ben: I need an owner review for the one_click_signin_dialog_views.cc file.

Fred: note that I added a new argument to ShowOneClickSigninDialog().  This will
affect your Mac UI work.

[Andrew T Wilson (Slow), 2012-03-06 20:42:46]

One question - is it intentional that session_index is passed around as a
string, not an int? I guess in theory it's just opaque to us and we don't care
what the contents are?

http://codereview.chromium.org/9592015/diff/2001/chrome/browser/ui/sync/one_c...
File chrome/browser/ui/sync/one_click_signin_helper.cc (right):

http://codereview.chromium.org/9592015/diff/2001/chrome/browser/ui/sync/one_c...
chrome/browser/ui/sync/one_click_signin_helper.cc:190: session_index =
pair.second;
Are we always guaranteed to have a session index, even if the user isn't using
multilogin?

http://codereview.chromium.org/9592015/diff/2001/chrome/common/net/gaia/gaia_...
File chrome/common/net/gaia/gaia_auth_fetcher.cc (right):

http://codereview.chromium.org/9592015/diff/2001/chrome/common/net/gaia/gaia_...
chrome/common/net/gaia/gaia_auth_fetcher.cc:535: url += session_index;
Can you do url += "?authuser=" + session_index; or will that not work?

[Roger Tawa OOO till Jul 10th, 2012-03-06 21:25:17]

Thanks Drew.  Comments addressed, changes uploaded.

The gaia folks asked me to treat the session index as a string.  Today though it
is simply an int value, but I was told there is a good chance this will change
in the future.

http://codereview.chromium.org/9592015/diff/2001/chrome/browser/ui/sync/one_c...
File chrome/browser/ui/sync/one_click_signin_helper.cc (right):

http://codereview.chromium.org/9592015/diff/2001/chrome/browser/ui/sync/one_c...
chrome/browser/ui/sync/one_click_signin_helper.cc:190: session_index =
pair.second;
On 2012/03/06 20:42:46, Andrew T Wilson wrote:
> Are we always guaranteed to have a session index, even if the user isn't using
> multilogin?

Yes.

http://codereview.chromium.org/9592015/diff/2001/chrome/common/net/gaia/gaia_...
File chrome/common/net/gaia/gaia_auth_fetcher.cc (right):

http://codereview.chromium.org/9592015/diff/2001/chrome/common/net/gaia/gaia_...
chrome/common/net/gaia/gaia_auth_fetcher.cc:535: url += session_index;
On 2012/03/06 20:42:46, Andrew T Wilson wrote:
> Can you do url += "?authuser=" + session_index; or will that not work?

Done.

[Andrew T Wilson (Slow), 2012-03-06 21:27:40]

LGTM

[Ben Goodger (Google), 2012-03-06 23:21:42]

lgtm

[commit-bot: I haz the power, 2012-03-06 23:23:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/9592015/15

[commit-bot: I haz the power, 2012-03-06 23:57:16]

Try job failure for 9592015-15 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-03-07 03:21:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/9592015/3019

[commit-bot: I haz the power, 2012-03-07 05:13:24]

Change committed as 125327