Issue 9716005: Close a stream when done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9716005: Close a stream when done (Closed)

Created:
8 years, 9 months ago by Brian Wilkerson

Modified:
8 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Close a stream when done Committed: https://code.google.com/p/dart/source/detail?r=5595

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/common/SourceInfo.java	View		3 chunks	+11 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM http://codereview.chromium.org/9716005/diff/1/compiler/java/com/google/dart/compiler/common/SourceInfo.java File compiler/java/com/google/dart/compiler/common/SourceInfo.java (right): http://codereview.chromium.org/9716005/diff/1/compiler/java/com/google/dart/compiler/common/SourceInfo.java#newcode92 compiler/java/com/google/dart/compiler/common/SourceInfo.java:92: if (reader != null) { com.google.common.io.Closeables.closeQuietly(Closeable) ?

8 years, 9 months ago (2012-03-16 21:33:22 UTC) #2

Brian Wilkerson

8 years, 9 months ago (2012-03-16 21:45:06 UTC) #3

http://codereview.chromium.org/9716005/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/common/SourceInfo.java (right):

http://codereview.chromium.org/9716005/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/common/SourceInfo.java:92: if (reader !=
null) {
On 2012/03/16 21:33:22, scheglov wrote:
> com.google.common.io.Closeables.closeQuietly(Closeable) ?

Sure, but in a later CL.

Expand Messages | Collapse Messages