Allow targeted links to work on tabs that have swapped out processes.

Allow targeted links to work on tabs that have swapped out processes.

BUG=116192
TEST=Click a target=foo link again after a cross-site nav in the window.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128298

[Charlie Reis, 2012-03-21 23:39:04]

Darin, can you review?

[darin (slow to review), 2012-03-22 17:23:39]

https://chromiumcodereview.appspot.com/9706047/diff/8001/content/renderer/ren...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/9706047/diff/8001/content/renderer/ren...
content/renderer/render_view_impl.cc:2258: OpenURL(frame, request.url(),
referrer, default_policy);
so if this is a POST request, then it will become a GET request.  are we OK with
that?  i'm guessing we aren't.

[darin (slow to review), 2012-03-22 17:24:22]

LGTM

[Charlie Reis, 2012-03-22 18:04:06]

https://chromiumcodereview.appspot.com/9706047/diff/8001/content/renderer/ren...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/9706047/diff/8001/content/renderer/ren...
content/renderer/render_view_impl.cc:2258: OpenURL(frame, request.url(),
referrer, default_policy);
On 2012/03/22 17:23:39, darin wrote:
> so if this is a POST request, then it will become a GET request.  are we OK
with
> that?  i'm guessing we aren't.

That's a fair point.  It seems better to convert targeted form posts to GETs for
now than to drop them on the floor, but it's something we should be able to
support when we fix cross-process POST submissions.   I'll add a TODO pointing
to http://crbug.com/101395.

[commit-bot: I haz the power, 2012-03-22 18:42:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/9706047/19001

[commit-bot: I haz the power, 2012-03-22 20:55:35]

Change committed as 128298