Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4959)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 9706017: Remove Ordinals Setters and Getters from ExtensionService (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index c0905049b4138e763afae4066cb812ba15ff6985..19da62407338740a82b06da85e744772315e96d9 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -125,6 +125,8 @@ class ExtensionServiceInterface : public SyncableService {
const std::string& extension_id,
extension_misc::UnloadedExtensionReason reason) = 0;
+ virtual void SyncExtensionChangeIfNeeded(const Extension& extension) = 0;
+
virtual bool is_ready() = 0;
};
@@ -227,17 +229,6 @@ class ExtensionService
virtual void SetAppNotificationDisabled(const std::string& extension_id,
bool value);
- // Getters and setters for the position of Apps in the NTP. The setters
- // will trigger a sync if needed.
- // The getters return invalid StringOridinals for non-app extensions and
- // setting ordinals for non-apps is an error.
- StringOrdinal GetAppLaunchOrdinal(const std::string& extension_id) const;
- void SetAppLaunchOrdinal(const std::string& extension_id,
- const StringOrdinal& app_launch_ordinal);
- StringOrdinal GetPageOrdinal(const std::string& extension_id) const;
- void SetPageOrdinal(const std::string& extension_id,
- const StringOrdinal& page_ordinal);
-
// Updates the app launcher value for the moved extension so that it is now
// located after the given predecessor and before the successor. This will
// trigger a sync if needed. Empty strings are used to indicate no successor
@@ -375,6 +366,10 @@ class ExtensionService
// Scan the extension directory and clean up the cruft.
void GarbageCollectExtensions();
+ // Notifies Sync (if needed) of a newly-installed extension or a change to
+ // an existing extension.
+ virtual void SyncExtensionChangeIfNeeded(const Extension& extension) OVERRIDE;
+
// The App that represents the web store.
const Extension* GetWebStoreApp();
@@ -634,10 +629,6 @@ class ExtensionService
};
typedef std::list<NaClModuleInfo> NaClModuleInfoList;
- // Notifies Sync (if needed) of a newly-installed extension or a change to
- // an existing extension.
- void SyncExtensionChangeIfNeeded(const Extension& extension);
-
// Get the appropriate SyncBundle, given some representation of Sync data.
SyncBundle* GetSyncBundleForExtension(const Extension& extension);
SyncBundle* GetSyncBundleForExtensionSyncData(
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698