Remove Ordinals Setters and Getters from ExtensionService

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #pragma once
 
 #include <list>
 #include <map>
@@ skipping 107 matching lines @@
   // themes sync to not use it directly.
   virtual void CheckForUpdatesSoon() = 0;
 
   // Returns true if the extension was successfully added.
   virtual bool AddExtension(const Extension* extension) = 0;
 
   virtual void UnloadExtension(
       const std::string& extension_id,
       extension_misc::UnloadedExtensionReason reason) = 0;
 
+  virtual void SyncExtensionChangeIfNeeded(const Extension& extension) = 0;
+
   virtual bool is_ready() = 0;
 };
 
 // Manages installed and running Chromium extensions.
 class ExtensionService
     : public ExtensionServiceInterface,
       public ExternalExtensionProviderInterface::VisitorInterface,
       public base::SupportsWeakPtr<ExtensionService>,
       public content::NotificationObserver {
  public:
@@ skipping 82 matching lines @@
 
   // When app notification setup is done, we call this to save the developer's
   // oauth client id which we'll need at uninstall time to revoke the oauth
   // permission grant for sending notifications.
   virtual void SetAppNotificationSetupDone(const std::string& extension_id,
                                            const std::string& oauth_client_id);
 
   virtual void SetAppNotificationDisabled(const std::string& extension_id,
       bool value);
 
-  // Getters and setters for the position of Apps in the NTP. The setters
-  // will trigger a sync if needed.
-  // The getters return invalid StringOridinals for non-app extensions and
-  // setting ordinals for non-apps is an error.
-  StringOrdinal GetAppLaunchOrdinal(const std::string& extension_id) const;
-  void SetAppLaunchOrdinal(const std::string& extension_id,
-                           const StringOrdinal& app_launch_ordinal);
-  StringOrdinal GetPageOrdinal(const std::string& extension_id) const;
-  void SetPageOrdinal(const std::string& extension_id,
-                      const StringOrdinal& page_ordinal);
-
   // Updates the app launcher value for the moved extension so that it is now
   // located after the given predecessor and before the successor. This will
   // trigger a sync if needed. Empty strings are used to indicate no successor
   // or predecessor.
   void OnExtensionMoved(const std::string& moved_extension_id,
                         const std::string& predecessor_extension_id,
                         const std::string& successor_extension_id);
 
   // Returns true if the given extension can see events and data from another
   // sub-profile (incognito to original profile, or vice versa).
@@ skipping 117 matching lines @@
   // Unload all extensions. This is currently only called on shutdown, and
   // does not send notifications.
   void UnloadAllExtensions();
 
   // Called only by testing.
   void ReloadExtensions();
 
   // Scan the extension directory and clean up the cruft.
   void GarbageCollectExtensions();
 
+  // Notifies Sync (if needed) of a newly-installed extension or a change to
+  // an existing extension.
+  virtual void SyncExtensionChangeIfNeeded(const Extension& extension) OVERRIDE;
+
   // The App that represents the web store.
   const Extension* GetWebStoreApp();
 
   // Returns true if |url| should get extension api bindings and be permitted
   // to make api calls. Note that this is independent of what extension
   // permissions the given extension has been granted.
   bool ExtensionBindingsAllowed(const GURL& url);
 
   // Returns the icon to display in the omnibox for the given extension.
   const SkBitmap& GetOmniboxIcon(const std::string& extension_id);
@@ skipping 239 matching lines @@
 
   struct NaClModuleInfo {
     NaClModuleInfo();
     ~NaClModuleInfo();
 
     GURL url;
     std::string mime_type;
   };
   typedef std::list<NaClModuleInfo> NaClModuleInfoList;
 
-  // Notifies Sync (if needed) of a newly-installed extension or a change to
-  // an existing extension.
-  void SyncExtensionChangeIfNeeded(const Extension& extension);
-
   // Get the appropriate SyncBundle, given some representation of Sync data.
   SyncBundle* GetSyncBundleForExtension(const Extension& extension);
   SyncBundle* GetSyncBundleForExtensionSyncData(
       const ExtensionSyncData& extension_sync_data);
   SyncBundle* GetSyncBundleForModelType(syncable::ModelType type);
   const SyncBundle* GetSyncBundleForModelTypeConst(syncable::ModelType type)
       const;
 
   // Gets the ExtensionSyncData for all extensions.
   std::vector<ExtensionSyncData> GetSyncDataList(
@@ skipping 199 matching lines @@
   scoped_ptr<ExtensionGlobalError> extension_global_error_;
 
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsWithUnlimtedStorage);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsAndCheckStorageProtection);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_