Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 9705083: Unknown options in extension manifest file are silently ignored (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changes per comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 75915b69f6ea2bcf914851af68aa97627e3c09f4..8dc1b55425590d128c1ced3e3fa6108af37e8b37 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -35,6 +35,7 @@
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/extension_set.h"
+#include "chrome/common/extensions/manifest.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/notification_service.h"
@@ -214,6 +215,17 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
extension_data->Set("installWarnings", list.release());
}
+ // Add unrecognized manifest keys.
+ const std::vector<std::string> unrecognized_keys =
+ extension->manifest()->GetUnrecognizedKeys();
+ if (!unrecognized_keys.empty()) {
+ scoped_ptr<ListValue> list(new ListValue());
+ std::vector<std::string>::const_iterator it;
+ for (it = unrecognized_keys.begin(); it != unrecognized_keys.end(); ++it)
+ list->Append(Value::CreateStringValue(*it));
+ extension_data->Set("unrecognizedKeys", list.release());
+ }
+
return extension_data;
}
@@ -247,6 +259,8 @@ void ExtensionSettingsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
localized_strings->SetString("extensionSettingsInstallWarnings",
l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS));
+ localized_strings->SetString("extensionSettingsUnrecognizedManifestKeys",
+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNRECOGNIZED_MANIFEST_KEYS));
localized_strings->SetString("viewIncognito",
l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
localized_strings->SetString("viewInactive",

Powered by Google App Engine
This is Rietveld 408576698