Unknown options in extension manifest file are silently ignored

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "base/auto_reset.h"
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 17 matching lines @@
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/background_contents.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_view_type.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/extension_set.h"
+#include "chrome/common/extensions/manifest.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
@@ skipping 159 matching lines @@
       extension->install_warnings();
   if (!install_warnings.empty()) {
     scoped_ptr<ListValue> list(new ListValue());
     for (std::vector<std::string>::const_iterator it = install_warnings.begin();
          it != install_warnings.end(); ++it) {
       list->Append(Value::CreateStringValue(*it));
     }
     extension_data->Set("installWarnings", list.release());
   }
 
+  // Add unrecognized manifest keys.
+  const std::vector<std::string> unrecognized_keys =
+      extension->manifest()->GetUnrecognizedKeys();
+  if (!unrecognized_keys.empty()) {
+    scoped_ptr<ListValue> list(new ListValue());
+    std::vector<std::string>::const_iterator it;
+    for (it = unrecognized_keys.begin(); it != unrecognized_keys.end(); ++it)
+      list->Append(Value::CreateStringValue(*it));
+    extension_data->Set("unrecognizedKeys", list.release());
+  }
+
   return extension_data;
 }
 
 void ExtensionSettingsHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   localized_strings->SetString("extensionSettings",
       l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE));
 
   localized_strings->SetString("extensionSettingsDeveloperMode",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK));
@@ skipping 13 matching lines @@
       ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
           GURL(extension_urls::GetWebstoreLaunchURL())).spec()));
   localized_strings->SetString("extensionSettingsExtensionId",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));
   localized_strings->SetString("extensionSettingsExtensionPath",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH));
   localized_strings->SetString("extensionSettingsInspectViews",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
   localized_strings->SetString("extensionSettingsInstallWarnings",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS));
+  localized_strings->SetString("extensionSettingsUnrecognizedManifestKeys",
+      l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNRECOGNIZED_MANIFEST_KEYS));
   localized_strings->SetString("viewIncognito",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
   localized_strings->SetString("viewInactive",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INACTIVE));
   localized_strings->SetString("extensionSettingsEnable",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ENABLE));
   localized_strings->SetString("extensionSettingsEnabled",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_ENABLED));
   localized_strings->SetString("extensionSettingsRemove",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_REMOVE));
@@ skipping 581 matching lines @@
   return extension_uninstall_dialog_.get();
 #else
   return NULL;
 #endif  // !defined(OS_ANDROID)
 }
 
 void ExtensionSettingsHandler::InspectExtensionHost(ExtensionHost* host) {
   if (host)
     DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
 }