Remove FFmpegVideoDecoder log spam and misleading comment.

media/filters/ffmpeg_video_decoder.cc

Index: media/filters/ffmpeg_video_decoder.cc
diff --git a/media/filters/ffmpeg_video_decoder.cc b/media/filters/ffmpeg_video_decoder.cc
index e68ff8406d11c8195bb3aa08e84dc9e211acda9c..81dd6b68f1a5717732146a06c035f7e024da6955 100644
--- a/media/filters/ffmpeg_video_decoder.cc
+++ b/media/filters/ffmpeg_video_decoder.cc
@@ -72,10 +72,6 @@ void FFmpegVideoDecoder::Initialize(DemuxerStream* demuxer_stream,
   if (!message_loop_) {
     message_loop_ = message_loop_factory_cb_.Run();
     message_loop_factory_cb_.Reset();
-  } else {
-    // TODO(scherkus): initialization currently happens more than once in
-    // PipelineIntegrationTest.BasicPlayback.
-    LOG(ERROR) << "Initialize has already been called.";

[acolwell GONE FROM CHROMIUM, 2012/03/15 01:17:39]

The comment is misleading and this LOG statement always runs. Initialize() gets
called again because of the block below. Initialize() was called on the Pipeline
thread and message_loop_ gets set to the "video decoder thread" MessageLoop. The
code below sees that the pipeline thread doesn't match the video thread so it
schedules another call on Initialize().

[Ami GONE FROM CHROMIUM, 2012/03/15 01:31:50]

This code is even more messed up than that now that the thread is created right
above us, the conditional for the trampoline below is extra-silly!
I think the PostTask below wants to live in the then-clause above.
Once that move is done I agree this else clause & its LOG can die; the
DCHECK(!demuxer_stream_) below will serve the same purpose of guarding against
double-initialize.

[acolwell GONE FROM CHROMIUM, 2012/03/15 13:55:16]

Good point. Done.

   }
 
   if (MessageLoop::current() != message_loop_) {