Remove FFmpegVideoDecoder log spam and misleading comment.

media/filters/ffmpeg_video_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/ffmpeg_video_decoder.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
@@ skipping 54 matching lines @@
 FFmpegVideoDecoder::~FFmpegVideoDecoder() {
   ReleaseFFmpegResources();
 }
 
 void FFmpegVideoDecoder::Initialize(DemuxerStream* demuxer_stream,
                                     const PipelineStatusCB& pipeline_status_cb,
                                     const StatisticsCB& statistics_cb) {
   if (!message_loop_) {
     message_loop_ = message_loop_factory_cb_.Run();
     message_loop_factory_cb_.Reset();
-  } else {
-    // TODO(scherkus): initialization currently happens more than once in
-    // PipelineIntegrationTest.BasicPlayback.
-    LOG(ERROR) << "Initialize has already been called.";

[acolwell GONE FROM CHROMIUM, 2012/03/15 01:17:39]

The comment is misleading and this LOG statement always runs. Initialize() gets
called again because of the block below. Initialize() was called on the Pipeline
thread and message_loop_ gets set to the "video decoder thread" MessageLoop. The
code below sees that the pipeline thread doesn't match the video thread so it
schedules another call on Initialize().

[Ami GONE FROM CHROMIUM, 2012/03/15 01:31:50]

This code is even more messed up than that now that the thread is created right
above us, the conditional for the trampoline below is extra-silly!
I think the PostTask below wants to live in the then-clause above.
Once that move is done I agree this else clause & its LOG can die; the
DCHECK(!demuxer_stream_) below will serve the same purpose of guarding against
double-initialize.

[acolwell GONE FROM CHROMIUM, 2012/03/15 13:55:16]

Good point. Done.

   }
 
   if (MessageLoop::current() != message_loop_) {
     message_loop_->PostTask(FROM_HERE, base::Bind(
         &FFmpegVideoDecoder::Initialize, this,
         make_scoped_refptr(demuxer_stream), pipeline_status_cb, statistics_cb));
     return;
   }
 
   DCHECK(!demuxer_stream_);
@@ skipping 358 matching lines @@
 scoped_refptr<VideoFrame> FFmpegVideoDecoder::AllocateVideoFrame() {
   VideoFrame::Format format = PixelFormatToVideoFormat(codec_context_->pix_fmt);
   size_t width = codec_context_->width;
   size_t height = codec_context_->height;
 
   return VideoFrame::CreateFrame(format, width, height,
                                  kNoTimestamp(), kNoTimestamp());
 }
 
 }  // namespace media