Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 9705045: Remove FFmpegVideoDecoder log spam and misleading comment. (Closed)

Created:
8 years, 9 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove FFmpegVideoDecoder log spam and misleading comment. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126977

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address CR comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M media/filters/ffmpeg_video_decoder.cc View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (left): http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc#oldcode78 media/filters/ffmpeg_video_decoder.cc:78: LOG(ERROR) << "Initialize has already been called."; The comment ...
8 years, 9 months ago (2012-03-15 01:17:39 UTC) #1
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (left): http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc#oldcode78 media/filters/ffmpeg_video_decoder.cc:78: LOG(ERROR) << "Initialize has already been called."; On 2012/03/15 ...
8 years, 9 months ago (2012-03-15 01:31:50 UTC) #2
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (left): http://codereview.chromium.org/9705045/diff/1/media/filters/ffmpeg_video_decoder.cc#oldcode78 media/filters/ffmpeg_video_decoder.cc:78: LOG(ERROR) << "Initialize has already been called."; On 2012/03/15 ...
8 years, 9 months ago (2012-03-15 13:55:16 UTC) #3
Ami GONE FROM CHROMIUM
lgtm
8 years, 9 months ago (2012-03-15 16:27:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/9705045/3001
8 years, 9 months ago (2012-03-15 16:31:55 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 20:15:43 UTC) #6
Change committed as 126977

Powered by Google App Engine
This is Rietveld 408576698