Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6022)

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 9703099: Revert 126959 - Re-factor location bar/toolbar code to get rid of the browser dependency. This CL i… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/command_updater_unittest.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_global_error_unittest.cc
===================================================================
--- chrome/browser/sync/sync_global_error_unittest.cc (revision 127082)
+++ chrome/browser/sync/sync_global_error_unittest.cc (working copy)
@@ -17,10 +17,9 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using ::testing::NiceMock;
using ::testing::Return;
using ::testing::ReturnRef;
-using ::testing::_;
+using ::testing::NiceMock;
using content::BrowserThread;
namespace {
@@ -29,8 +28,7 @@
public:
explicit BrowserMock(Type type, Profile* profile) : Browser(type, profile) {}
- MOCK_METHOD2(ExecuteCommandWithDisposition,
- void(int command_id, WindowOpenDisposition));
+ MOCK_METHOD1(ExecuteCommand, void(int command_id));
};
// Same as BrowserWithTestWindowTest, but uses MockBrowser to test calls to
@@ -89,8 +87,7 @@
#if defined(OS_CHROMEOS)
if (error_state != GoogleServiceAuthError::NONE) {
// In CrOS sign-in/sign-out is made to fix the error.
- EXPECT_CALL(*static_cast<BrowserMock*>(browser),
- ExecuteCommandWithDisposition(IDC_EXIT, _));
+ EXPECT_CALL(*static_cast<BrowserMock*>(browser), ExecuteCommand(IDC_EXIT));
error->ExecuteMenuItem(browser);
}
#else
« no previous file with comments | « chrome/browser/command_updater_unittest.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698