Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/ui/browser.h

Issue 9703099: Revert 126959 - Re-factor location bar/toolbar code to get rid of the browser dependency. This CL i… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_global_error_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
===================================================================
--- chrome/browser/ui/browser.h (revision 127082)
+++ chrome/browser/ui/browser.h (working copy)
@@ -52,9 +52,7 @@
#include "ui/base/ui_base_types.h"
#include "ui/gfx/rect.h"
-class BrowserContentSettingBubbleModelDelegate;
class BrowserSyncedWindowDelegate;
-class BrowserToolbarModelDelegate;
class BrowserTabRestoreServiceDelegate;
class BrowserWindow;
class Extension;
@@ -236,14 +234,10 @@
// |window()| will return NULL if called before |CreateBrowserWindow()|
// is done.
BrowserWindow* window() const { return window_; }
- ToolbarModel* toolbar_model() { return toolbar_model_.get(); }
+ ToolbarModel* toolbar_model() { return &toolbar_model_; }
const SessionID& session_id() const { return session_id_; }
CommandUpdater* command_updater() { return &command_updater_; }
bool block_command_execution() const { return block_command_execution_; }
- BrowserContentSettingBubbleModelDelegate*
- content_setting_bubble_model_delegate() {
- return content_setting_bubble_model_delegate_.get();
- }
BrowserTabRestoreServiceDelegate* tab_restore_service_delegate() {
return tab_restore_service_delegate_.get();
}
@@ -755,8 +749,8 @@
static void UpdateTargetURLHelper(content::WebContents* tab, int32 page_id,
const GURL& url);
- // Calls ExecuteCommandWithDisposition with CURRENT_TAB disposition.
- void ExecuteCommand(int id);
+ // Calls ExecuteCommandWithDisposition with the given disposition.
+ void ExecuteCommandWithDisposition(int id, WindowOpenDisposition);
// Calls ExecuteCommandWithDisposition with the given event flags.
void ExecuteCommand(int id, int event_flags);
@@ -799,9 +793,7 @@
const content::OpenURLParams& params) OVERRIDE;
// Overridden from CommandUpdater::CommandUpdaterDelegate:
- virtual void ExecuteCommandWithDisposition(
- int id,
- WindowOpenDisposition disposition) OVERRIDE;
+ virtual void ExecuteCommand(int id) OVERRIDE;
// Overridden from TabRestoreServiceObserver:
virtual void TabRestoreServiceChanged(TabRestoreService* service) OVERRIDE;
@@ -1370,7 +1362,7 @@
const SessionID session_id_;
// The model for the toolbar view.
- scoped_ptr<ToolbarModel> toolbar_model_;
+ ToolbarModel toolbar_model_;
// UI update coalescing and handling ////////////////////////////////////////
@@ -1464,13 +1456,6 @@
// and we install ourselves as an observer.
TabRestoreService* tab_restore_service_;
- // Helper which implements the ContentSettingBubbleModel interface.
- scoped_ptr<BrowserContentSettingBubbleModelDelegate>
- content_setting_bubble_model_delegate_;
-
- // Helper which implements the ToolbarModelDelegate interface.
- scoped_ptr<BrowserToolbarModelDelegate> toolbar_model_delegate_;
-
// Helper which implements the TabRestoreServiceDelegate interface.
scoped_ptr<BrowserTabRestoreServiceDelegate> tab_restore_service_delegate_;
« no previous file with comments | « chrome/browser/sync/sync_global_error_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698