Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9703099: Revert 126959 - Re-factor location bar/toolbar code to get rid of the browser dependency. This CL i… (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
Reviewers:
altimofeev
CC:
chromium-reviews, Raghu Simha, ncarter (slow), James Su, akalin, tim (not reviewing)
Visibility:
Public.

Description

Revert 126959 - Re-factor location bar/toolbar code to get rid of the browser dependency. This CL is needed to allow code reusing by captive portal view, which will show web content using DomView. BUG=chromium-os:22630 TEST=browser_tests,unit_tests works Review URL: http://codereview.chromium.org/9479008 TBR=altimofeev@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -541 lines) Patch
M chrome/browser/command_updater.h View 4 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/command_updater.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/command_updater_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.h View 6 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/ui/browser.cc View 8 chunks +112 lines, -121 lines 0 comments Download
D chrome/browser/ui/browser_content_setting_bubble_model_delegate.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/browser_toolbar_model_delegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/browser_toolbar_model_delegate.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 10 chunks +26 lines, -26 lines 0 comments Download
D chrome/browser/ui/content_settings/content_setting_bubble_model_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
MM chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.h View 4 chunks +4 lines, -4 lines 0 comments Download
MM chrome/browser/ui/toolbar/toolbar_model.cc View 5 chunks +6 lines, -6 lines 0 comments Download
D chrome/browser/ui/toolbar/toolbar_model_delegate.h View 1 chunk +0 lines, -23 lines 0 comments Download
chrome/browser/ui/views/location_bar/click_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 6 chunks +5 lines, -44 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 13 chunks +34 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/reload_button.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/reload_button.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 4 chunks +2 lines, -30 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
8 years, 9 months ago (2012-03-16 02:14:52 UTC) #1
Lei Zhang
8 years, 9 months ago (2012-03-16 02:20:42 UTC) #2 
Sorry I had to revert this. On Linux, when I hit ctrl+r on the keyboard, it does
not reload. Instead, it duplicates the current tab in a new window. Yikes.

Powered by Google App Engine
This is Rietveld 408576698