Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: dbus/values_util.cc

Issue 9700072: dbus: add support for passing file descriptors (Closed) Base URL: http://git.chromium.org/git/chromium/src@master
Patch Set: add dbus::FileDescriptor per keybuk's request Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dbus/message_unittest.cc ('K') | « dbus/message_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/values_util.cc
diff --git a/dbus/values_util.cc b/dbus/values_util.cc
index e341ac235ce5dae8d60612ff1b4eddee933f8922..accf05ba218e21a33d1ae82965e0cc2580815c9f 100644
--- a/dbus/values_util.cc
+++ b/dbus/values_util.cc
@@ -163,6 +163,13 @@ Value* PopDataAsValue(MessageReader* reader) {
result = Value::CreateStringValue(value.value());
break;
}
+#if defined(DBUS_TYPE_UNIX_FD)
+ case Message::UNIX_FD: {
+ // Cannot distinguish fd from an int at the moment
keybuk 2012/03/27 22:36:35 Sure you can, it's a dbus::FileDescriptor now ;-)
Sam Leffler 2012/03/27 23:20:40 Previously I took the fd and stashed it in an inte
satorux1 2012/03/28 00:32:43 NOTREACHED() sounds reasonable to me.
+ NOTREACHED();
+ break;
+ }
+#endif
case Message::ARRAY: {
MessageReader sub_reader(NULL);
if (reader->PopArray(&sub_reader)) {
« dbus/message_unittest.cc ('K') | « dbus/message_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698