dbus: add support for passing file descriptors

dbus/values_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/values_util.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
@@ skipping 145 matching lines @@
       if (reader->PopString(&value))
         result = Value::CreateStringValue(value);
       break;
     }
     case Message::OBJECT_PATH: {
       ObjectPath value;
       if (reader->PopObjectPath(&value))
         result = Value::CreateStringValue(value.value());
       break;
     }
+#if defined(DBUS_TYPE_UNIX_FD)
+    case Message::UNIX_FD: {
+      // Cannot distinguish fd from an int at the moment

[keybuk, 2012/03/27 22:36:35]

Sure you can, it's a dbus::FileDescriptor now ;-)

[Sam Leffler, 2012/03/27 23:20:40]

Previously I took the fd and stashed it in an integer Value but then the caller
can't distinguish it from another integer Value. I'm not sure it's worth adding
it right now but rather than explicitly leak the fd I changed this code.

[satorux1, 2012/03/28 00:32:43]

NOTREACHED() sounds reasonable to me. 

+      NOTREACHED();
+      break;
+    }
+#endif
     case Message::ARRAY: {
       MessageReader sub_reader(NULL);
       if (reader->PopArray(&sub_reader)) {
         // If the type of the array's element is DICT_ENTRY, create a
         // DictionaryValue, otherwise create a ListValue.
         if (sub_reader.GetDataType() == Message::DICT_ENTRY) {
           scoped_ptr<DictionaryValue> dictionary_value(new DictionaryValue);
           if (PopDictionaryEntries(&sub_reader, dictionary_value.get()))
             result = dictionary_value.release();
         } else {
@@ skipping 61 matching lines @@
 
 void AppendBasicTypeValueDataAsVariant(MessageWriter* writer,
                                        const base::Value& value) {
   MessageWriter sub_writer(NULL);
   writer->OpenVariant(GetTypeSignature(value), &sub_writer);
   AppendBasicTypeValueData(&sub_writer, value);
   writer->CloseContainer(&sub_writer);
 }
 
 }  // namespace dbus