chrome/browser/resources/print_preview/margin_settings.js - Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/margin_settings.js

Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: addressed review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/header_footer_settings.js ('K') | « chrome/browser/resources/print_preview/header_footer_settings.js ('k') | chrome/browser/resources/print_preview/print_preview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/margin_settings.js

diff --git a/chrome/browser/resources/print_preview/margin_settings.js b/chrome/browser/resources/print_preview/margin_settings.js

index 9faa640475bc6399a5151a9ba0065cdc6e19b7dd..0ffca9f9e8858b05123d023c422d4ed555481e94 100644

--- a/chrome/browser/resources/print_preview/margin_settings.js

+++ b/chrome/browser/resources/print_preview/margin_settings.js

@@ -240,13 +240,6 @@ cr.define('print_preview', function() {

this.customMargins_ = new Margins(-1, -1, -1 , -1);

this.customMargins = lastUsedMarginsSettings;

}

- this.dispatchMarginsChangedEvent_();

- },

- dispatchMarginsChangedEvent_: function() {

- var customEvent = cr.Event(customEvents.MARGINS_SELECTION_CHANGED);

- customEvent.selectedMargins = this.selectedMarginsValue;

- document.dispatchEvent(customEvent);

/**

@@ -567,8 +560,6 @@ cr.define('print_preview', function() {

* @private

onMarginsChanged_: function() {

- this.dispatchMarginsChangedEvent_();

if (this.isDefaultMarginsSelected() || this.isMinimumMarginsSelected() ||

this.isNoMarginsSelected())

this.onDefaultMinimumNoMarginsSelected_();