Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/resources/print_preview/header_footer_settings.js

Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: addressed review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/header_footer_settings.js
diff --git a/chrome/browser/resources/print_preview/header_footer_settings.js b/chrome/browser/resources/print_preview/header_footer_settings.js
index 02776c58b86b8e351e8924dd57ebe07423b36e74..53e89de575874d0936fa4f374a03f89bded4864d 100644
--- a/chrome/browser/resources/print_preview/header_footer_settings.js
+++ b/chrome/browser/resources/print_preview/header_footer_settings.js
@@ -13,7 +13,6 @@ cr.define('print_preview', function() {
function HeaderFooterSettings() {
this.headerFooterOption_ = $('header-footer-option');
this.headerFooterCheckbox_ = $('header-footer');
- this.headerFooterApplies_ = false;
this.addEventListeners_();
}
@@ -33,7 +32,7 @@ cr.define('print_preview', function() {
* @return {boolean} true if Headers and Footers are checked.
*/
hasHeaderFooter: function() {
- return this.headerFooterApplies_ && this.headerFooterCheckbox_.checked;
+ return previewModifiable && this.headerFooterCheckbox_.checked;
},
/**
@@ -54,14 +53,6 @@ cr.define('print_preview', function() {
this.onHeaderFooterChanged_.bind(this);
document.addEventListener(customEvents.PDF_LOADED,
this.onPDFLoaded_.bind(this));
- document.addEventListener(customEvents.MARGINS_SELECTION_CHANGED,
- this.onMarginsSelectionChanged_.bind(this));
- },
-
- onMarginsSelectionChanged_: function(event) {
- this.headerFooterApplies_ = event.selectedMargins !=
- print_preview.MarginSettings.MARGINS_VALUE_NO_MARGINS;
- this.setVisible_(this.headerFooterApplies_);
},
/**
@@ -86,9 +77,8 @@ cr.define('print_preview', function() {
* Hides or shows |this.headerFooterOption|.
* @param {boolean} visible True if |this.headerFooterOption| should be
* shown.
- * @private
*/
- setVisible_: function(visible) {
+ setVisible: function(visible) {
if (visible)
fadeInOption(this.headerFooterOption_);
else
« no previous file with comments | « chrome/browser/printing/print_preview_message_handler.cc ('k') | chrome/browser/resources/print_preview/margin_settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698