PrintPreview: Hide/Show the header footer option based on print frame margins.

chrome/browser/resources/print_preview/header_footer_settings.js

Index: chrome/browser/resources/print_preview/header_footer_settings.js
diff --git a/chrome/browser/resources/print_preview/header_footer_settings.js b/chrome/browser/resources/print_preview/header_footer_settings.js
index 02776c58b86b8e351e8924dd57ebe07423b36e74..c59d58e88349f1af07c8e8918f0ef0d84cb53284 100644
--- a/chrome/browser/resources/print_preview/header_footer_settings.js
+++ b/chrome/browser/resources/print_preview/header_footer_settings.js
@@ -13,7 +13,6 @@ cr.define('print_preview', function() {
   function HeaderFooterSettings() {
     this.headerFooterOption_ = $('header-footer-option');
     this.headerFooterCheckbox_ = $('header-footer');
-    this.headerFooterApplies_ = false;
     this.addEventListeners_();
   }
 
@@ -33,7 +32,7 @@ cr.define('print_preview', function() {
      * @return {boolean} true if Headers and Footers are checked.
      */
     hasHeaderFooter: function() {
-      return this.headerFooterApplies_ && this.headerFooterCheckbox_.checked;
+      return previewModifiable && this.headerFooterCheckbox_.checked;
     },
 
     /**
@@ -54,14 +53,15 @@ cr.define('print_preview', function() {
           this.onHeaderFooterChanged_.bind(this);
       document.addEventListener(customEvents.PDF_LOADED,
                                 this.onPDFLoaded_.bind(this));
-      document.addEventListener(customEvents.MARGINS_SELECTION_CHANGED,
-                                this.onMarginsSelectionChanged_.bind(this));
     },
 
-    onMarginsSelectionChanged_: function(event) {
-      this.headerFooterApplies_ = event.selectedMargins !=
-          print_preview.MarginSettings.MARGINS_VALUE_NO_MARGINS;
-      this.setVisible_(this.headerFooterApplies_);
+    /**
+     * Sets the visibility of header footer option.
+     * @param {boolean} headerFooterApplies True if the headers footers
+     *     checkbox shoud be hidden, else false.
+     */
+    setVisibility: function(headerFooterApplies) {

[dpapad, 2012/03/14 23:16:25]

There is already a method setVisible_ in this class. Just make it public and use
it directly. setVisibility() is not needed.

[kmadhusu, 2012/03/15 00:19:15]

Done.

+      this.setVisible_(headerFooterApplies);
     },
 
     /**