chrome/browser/printing/print_preview_message_handler.cc - Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 9699040: PrintPreview: Hide/Show the header footer option based on print frame margins. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: '' Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_message_handler.h ('k') | chrome/browser/resources/print_preview/header_footer_settings.js » ('j') | chrome/browser/resources/print_preview/header_footer_settings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_message_handler.cc

diff --git a/chrome/browser/printing/print_preview_message_handler.cc b/chrome/browser/printing/print_preview_message_handler.cc

index d1cfb3c53787cd47628030b0221f2f09eb73246a..471fb404b68ea3353e59ac4fdaccb6a43cd1816c 100644

--- a/chrome/browser/printing/print_preview_message_handler.cc

+++ b/chrome/browser/printing/print_preview_message_handler.cc

@@ -204,7 +204,8 @@ void PrintPreviewMessageHandler::OnPrintPreviewFailed(int document_cookie) {

void PrintPreviewMessageHandler::OnDidGetDefaultPageLayout(

const PageSizeMargins& page_layout_in_points,

- bool has_custom_page_size_style) {

+ bool has_custom_page_size_style,

+ bool header_footer_applies) {

TabContentsWrapper* print_preview_tab = GetPrintPreviewTab();

if (!print_preview_tab || !print_preview_tab->web_contents()->GetWebUI())

return;

@@ -212,7 +213,8 @@ void PrintPreviewMessageHandler::OnDidGetDefaultPageLayout(

PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(

print_preview_tab->web_contents()->GetWebUI()->GetController());

print_preview_ui->OnDidGetDefaultPageLayout(page_layout_in_points,

- has_custom_page_size_style);

+ has_custom_page_size_style,

+ header_footer_applies);

}

void PrintPreviewMessageHandler::OnPrintPreviewCancelled(int document_cookie) {