Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 9699035: Reduce unnecessary network connections. (Closed)

Created:
8 years, 9 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reduce unnecessary network connections. Two different scenarios are fixed by this: a) When Range:0- receives a 200 request, don't make a new connection asking for the same data without the Range:0- request heaeder (bug 104783). b) When a 4xx or malformed HTTP response is received on a Range:0- request, don't re-attempt the request without the Range header (bug 105230). BUG=104783, 105230 TEST=awesome scherkus@ tests now pass w/ the extra expectations removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126970

Patch Set 1 #

Total comments: 6

Patch Set 2 : acolwell CR responses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -63 lines) Patch
M webkit/media/buffered_data_source.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/media/buffered_data_source.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M webkit/media/buffered_data_source_unittest.cc View 4 chunks +0 lines, -31 lines 0 comments Download
M webkit/media/buffered_resource_loader.cc View 1 2 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ami GONE FROM CHROMIUM
Andrew/Aaron: please review (I want both sets of eyes on this CL). Thanks.
8 years, 9 months ago (2012-03-14 17:55:28 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM w/ minor comments https://chromiumcodereview.appspot.com/9699035/diff/1/webkit/media/buffered_data_source.cc File webkit/media/buffered_data_source.cc (right): https://chromiumcodereview.appspot.com/9699035/diff/1/webkit/media/buffered_data_source.cc#newcode45 webkit/media/buffered_data_source.cc:45: using_range_request_(true), I think this can ...
8 years, 9 months ago (2012-03-14 18:24:49 UTC) #2
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/9699035/diff/1/webkit/media/buffered_data_source.cc File webkit/media/buffered_data_source.cc (right): https://chromiumcodereview.appspot.com/9699035/diff/1/webkit/media/buffered_data_source.cc#newcode45 webkit/media/buffered_data_source.cc:45: using_range_request_(true), On 2012/03/14 18:24:49, acolwell wrote: > I think ...
8 years, 9 months ago (2012-03-14 19:37:20 UTC) #3
Ami GONE FROM CHROMIUM
scherkus: landing CL now but still hoping you'll take a look at it when you're ...
8 years, 9 months ago (2012-03-15 17:10:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9699035/6
8 years, 9 months ago (2012-03-15 17:14:28 UTC) #5
commit-bot: I haz the power
Change committed as 126970
8 years, 9 months ago (2012-03-15 19:42:23 UTC) #6
scherkus (not reviewing)
8 years, 9 months ago (2012-03-22 14:00:53 UTC) #7
LGTM

me gusta the red-to-green ratio

Powered by Google App Engine
This is Rietveld 408576698