Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: webkit/media/buffered_data_source_unittest.cc

Issue 9699035: Reduce unnecessary network connections. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: acolwell CR responses. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/buffered_data_source.cc ('k') | webkit/media/buffered_resource_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/buffered_data_source_unittest.cc
diff --git a/webkit/media/buffered_data_source_unittest.cc b/webkit/media/buffered_data_source_unittest.cc
index 668063325a3ed947e45d75b9421f7e8ce04d5d4b..bb7c8be47b87de89642e26eb0c142c4786c1238e 100644
--- a/webkit/media/buffered_data_source_unittest.cc
+++ b/webkit/media/buffered_data_source_unittest.cc
@@ -202,14 +202,6 @@ TEST_F(BufferedDataSourceTest, Range_Supported) {
TEST_F(BufferedDataSourceTest, Range_NotFound) {
Initialize(media::PIPELINE_ERROR_NETWORK);
-
- // It'll try again.
- //
- // TODO(scherkus): don't try again on errors http://crbug.com/105230
- ExpectCreateResourceLoader();
- Respond(response_generator_.Generate404());
-
- // Now it's done and will fail.
Respond(response_generator_.Generate404());
EXPECT_FALSE(data_source_->loading());
@@ -218,14 +210,6 @@ TEST_F(BufferedDataSourceTest, Range_NotFound) {
TEST_F(BufferedDataSourceTest, Range_NotSupported) {
Initialize(media::PIPELINE_OK);
-
- // It'll try again.
- //
- // TODO(scherkus): try to reuse existing connection http://crbug.com/104783
- ExpectCreateResourceLoader();
- Respond(response_generator_.Generate200());
-
- // Now it'll succeed.
EXPECT_CALL(host_, SetTotalBytes(response_generator_.content_length()));
EXPECT_CALL(host_, SetBufferedBytes(0));
Respond(response_generator_.Generate200());
@@ -237,15 +221,6 @@ TEST_F(BufferedDataSourceTest, Range_NotSupported) {
TEST_F(BufferedDataSourceTest, Range_MissingContentRange) {
Initialize(media::PIPELINE_ERROR_NETWORK);
-
- // It'll try again.
- //
- // TODO(scherkus): don't try again on errors http://crbug.com/105230
- ExpectCreateResourceLoader();
- Respond(response_generator_.Generate206(
- 0, TestResponseGenerator::kNoContentRange));
-
- // Now it's done and will fail.
Respond(response_generator_.Generate206(
0, TestResponseGenerator::kNoContentRange));
@@ -269,12 +244,6 @@ TEST_F(BufferedDataSourceTest, Range_MissingContentLength) {
TEST_F(BufferedDataSourceTest, Range_WrongContentRange) {
Initialize(media::PIPELINE_ERROR_NETWORK);
- // It'll try again.
- //
- // TODO(scherkus): don't try again on errors http://crbug.com/105230
- ExpectCreateResourceLoader();
- Respond(response_generator_.Generate206(1337));
-
// Now it's done and will fail.
Respond(response_generator_.Generate206(1337));
« no previous file with comments | « webkit/media/buffered_data_source.cc ('k') | webkit/media/buffered_resource_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698