Start better error reporting for sockets

runtime/bin/socket_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <winsock2.h>
 #include <ws2tcpip.h>
 #include <mswsock.h>
 
 #include "bin/builtin.h"
 #include "bin/eventhandler.h"
@@ skipping 126 matching lines @@
   ListenSocket* listen_socket = reinterpret_cast<ListenSocket*>(fd);
   ClientSocket* client_socket = listen_socket->Accept();
   if (client_socket != NULL) {
     return reinterpret_cast<intptr_t>(client_socket);
   } else {
     return -1;
   }
 }
 
 
+const char* Socket::LookupIPv4Address(char* host, OSError** os_error) {
+  // Perform a name lookup for an IPv4 address.
+  struct addrinfo hints;
+  memset(&hints, 0, sizeof(hints));
+  hints.ai_family = AF_INET;
+  hints.ai_socktype = SOCK_STREAM;
+  hints.ai_protocol = IPPROTO_TCP;
+  struct addrinfo* info = NULL;
+  int status = getaddrinfo(host, 0, &hints, &info);
+  if (status != 0) {
+    ASSERT(*os_error == NULL);
+    *os_error = new OSError(status,
+                            gai_strerror(status),
+                            OSError::kGetAddressInfo);
+    (*os_error)->set_code(status);
+    (*os_error)->SetMessage(gai_strerror(status));
+    return NULL;
+  }
+  // Convert the address into IPv4 dotted decomal notation.

[Mads Ager (google), 2012/03/14 12:51:51]

Ditto.

[Søren Gjesse, 2012/03/19 10:05:43]

Done.

+  char* buffer = reinterpret_cast<char*>(malloc(INET_ADDRSTRLEN));
+  sockaddr_in *sockaddr = reinterpret_cast<sockaddr_in *>(info->ai_addr);
+  const char* result = inet_ntop(AF_INET,
+                                 reinterpret_cast<void *>(&sockaddr->sin_addr),
+                                 buffer,
+                                 INET_ADDRSTRLEN);
+  if (result == NULL) {
+    free(buffer);
+    return NULL;
+  }
+  ASSERT(result == buffer);
+  return buffer;
+}
+
+
 intptr_t ServerSocket::CreateBindListen(const char* host,
                                         intptr_t port,
                                         intptr_t backlog) {
   SOCKET s = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
   if (s == INVALID_SOCKET) {
     fprintf(stderr, "Error CreateBindListen: %d\n", WSAGetLastError());
     return -1;
   }
 
   BOOL optval = true;
@@ skipping 25 matching lines @@
   status = listen(s, backlog);
   if (status == SOCKET_ERROR) {
     fprintf(stderr, "Error socket listen: %d\n", WSAGetLastError());
     closesocket(s);
     return -1;
   }
 
   ListenSocket* listen_socket = new ListenSocket(s);
   return reinterpret_cast<intptr_t>(listen_socket);
 }