Start better error reporting for sockets

Start better error reporting for sockets

Changed the onError callback for sockets to take an exception argument.

First area to report errors for is name resolution.

Changed the IP address resolution from being synchronous with the
creation of the socket to being asynchronous thsough a lookup
service running on a native port. Currently this lookup service
is static on the socket class as we need to call it from a
factory method. We should probably add a separate name lookup
service at some point.

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5640

[Mads Ager (google), 2012-03-14 12:51:50]

LGTM

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/http_imp...
runtime/bin/http_impl.dart:1075:
_onError(HttpStatus.NETWORK_CONNECT_TIMEOUT_ERROR);
Do interpolation as above? Or doens't it make sense here?

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/io.dart
File runtime/bin/io.dart (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/io.dart#...
runtime/bin/io.dart:14: #import("dart:builtin");
Debugging code?

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
File runtime/bin/socket_impl.dart (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:67: eventHandler(new SocketIOException(""));
I suppose next step is to find a way to actually propagate some information
here?

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:270: // host on the given port. Null is returned if
file descriptor creation
Update description. Maybe in the public API as well?

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:276: request[0] = 0;
Maybe create a kHostLookup constant?

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:284: return null;
No need for the null return here.

We should probably report an error here or something? We used to return null
which the user could see. Now we don't.

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_i...
runtime/bin/socket_impl.dart:410: onError(new Exception("Unknown error"));
End the default case with a break as well.

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_l...
File runtime/bin/socket_linux.cc (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_l...
runtime/bin/socket_linux.cc:128: // Convert the address into IPv4 dotted decomal
notation.
decomal -> decimal

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_m...
File runtime/bin/socket_macos.cc (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_m...
runtime/bin/socket_macos.cc:128: // Convert the address into IPv4 dotted decomal
notation.
Ditto.

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_w...
File runtime/bin/socket_win.cc (right):

https://chromiumcodereview.appspot.com/9699017/diff/1025/runtime/bin/socket_w...
runtime/bin/socket_win.cc:165: // Convert the address into IPv4 dotted decomal
notation.
Ditto.

[Søren Gjesse, 2012-03-19 10:05:42]

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/http_impl.dart#n...
runtime/bin/http_impl.dart:1075:
_onError(HttpStatus.NETWORK_CONNECT_TIMEOUT_ERROR);
On 2012/03/14 12:51:51, Mads Ager wrote:
> Do interpolation as above? Or doens't it make sense here?

For some odd reason this onError currently takes a HttpStatus. This will be
changed in an upcoming change.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/io.dart
File runtime/bin/io.dart (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/io.dart#newcode14
runtime/bin/io.dart:14: #import("dart:builtin");
On 2012/03/14 12:51:51, Mads Ager wrote:
> Debugging code?

Removed.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:67: eventHandler(new SocketIOException(""));
On 2012/03/14 12:51:51, Mads Ager wrote:
> I suppose next step is to find a way to actually propagate some information
> here?

Yes.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:270: // host on the given port. Null is returned if
file descriptor creation
On 2012/03/14 12:51:51, Mads Ager wrote:
> Update description. Maybe in the public API as well?

Done.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:276: request[0] = 0;
On 2012/03/14 12:51:51, Mads Ager wrote:
> Maybe create a kHostLookup constant?

Done.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:284: return null;
On 2012/03/14 12:51:51, Mads Ager wrote:
> No need for the null return here.
> 
> We should probably report an error here or something? We used to return null
> which the user could see. Now we don't.

Good catch. Changed to do an onError callback when initiating connecting the
socket fails.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:410: onError(new Exception("Unknown error"));
On 2012/03/14 12:51:51, Mads Ager wrote:
> End the default case with a break as well.

Done.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_linux.cc
File runtime/bin/socket_linux.cc (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_linux.cc#...
runtime/bin/socket_linux.cc:128: // Convert the address into IPv4 dotted decomal
notation.
On 2012/03/14 12:51:51, Mads Ager wrote:
> decomal -> decimal

Done.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_macos.cc
File runtime/bin/socket_macos.cc (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_macos.cc#...
runtime/bin/socket_macos.cc:128: // Convert the address into IPv4 dotted decomal
notation.
On 2012/03/14 12:51:51, Mads Ager wrote:
> Ditto.

Done.

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_win.cc
File runtime/bin/socket_win.cc (right):

http://codereview.chromium.org/9699017/diff/1025/runtime/bin/socket_win.cc#ne...
runtime/bin/socket_win.cc:165: // Convert the address into IPv4 dotted decomal
notation.
On 2012/03/14 12:51:51, Mads Ager wrote:
> Ditto.

Done.