Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 9695043: Guard off two more places for ENABLE_NOTIFICATIONS (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Guard off two more places for ENABLE_NOTIFICATIONS These were missed in http://codereview.chromium.org/9447034/ BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/profiles/profile_dependency_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yaron
erg: please look at profiles jcivelli: chrome/test/base
8 years, 9 months ago (2012-03-13 13:55:55 UTC) #1
Jay Civelli
lgtm
8 years, 9 months ago (2012-03-13 16:05:30 UTC) #2
Yaron
On 2012/03/13 16:05:30, Jay Civelli wrote: > lgtm erg: can you please look at chrome/browser/profiles
8 years, 9 months ago (2012-03-15 13:54:00 UTC) #3
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-03-15 16:34:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9695043/1
8 years, 9 months ago (2012-03-15 16:54:53 UTC) #5
commit-bot: I haz the power
Try job failure for 9695043-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 20:15:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9695043/1
8 years, 9 months ago (2012-03-15 23:11:07 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 02:39:33 UTC) #8
Change committed as 127089

Powered by Google App Engine
This is Rietveld 408576698