Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/browser/in_process_webkit/layout_browsertest.h

Issue 9693065: Run IDB layout test suite as browser tests instead of ui tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: var renames Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/in_process_webkit/layout_browsertest.h
diff --git a/content/browser/in_process_webkit/layout_browsertest.h b/content/browser/in_process_webkit/layout_browsertest.h
new file mode 100644
index 0000000000000000000000000000000000000000..903b87a611aa06dc807fb6bd1becb88d7711f895
--- /dev/null
+++ b/content/browser/in_process_webkit/layout_browsertest.h
@@ -0,0 +1,26 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/file_path.h"
+#include "base/scoped_temp_dir.h"
+#include "chrome/test/base/in_process_browser_test.h"
+
+class InProcessBrowserLayoutTest : public InProcessBrowserTest {
+ public:
+ InProcessBrowserLayoutTest(const FilePath relative_layout_test_path);
jam 2012/03/16 21:42:11 nit: explicit
dgrogan 2012/03/16 22:18:35 Done.
+ virtual ~InProcessBrowserLayoutTest();
+
+ virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
+ void RunLayoutTest(const std::string& test_case_file_name);
+ void AddResourceForLayoutTest(const FilePath& parent_dir,
+ const FilePath& resource_name);
+
+ private:
+ void WriteModifiedFile(const std::string& test_case_file_name,
+ GURL* test_url);
jam 2012/03/16 21:42:11 nit: we usually separate the methods and variables
dgrogan 2012/03/16 22:18:35 Done.
+ FilePath our_original_layout_test_dir_;
+ FilePath original_relative_path_;
+ FilePath our_layout_test_temp_dir_;
+ ScopedTempDir scoped_temp_dir_;
jam 2012/03/16 21:42:11 nit DISALLOW_COPY_...
dgrogan 2012/03/16 22:18:35 Done.
+};

Powered by Google App Engine
This is Rietveld 408576698