Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: content/browser/in_process_webkit/layout_browsertest.h

Issue 9693065: Run IDB layout test suite as browser tests instead of ui tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: var renames Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/file_path.h"
6 #include "base/scoped_temp_dir.h"
7 #include "chrome/test/base/in_process_browser_test.h"
8
9 class InProcessBrowserLayoutTest : public InProcessBrowserTest {
10 public:
11 InProcessBrowserLayoutTest(const FilePath relative_layout_test_path);
jam 2012/03/16 21:42:11 nit: explicit
dgrogan 2012/03/16 22:18:35 Done.
12 virtual ~InProcessBrowserLayoutTest();
13
14 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
15 void RunLayoutTest(const std::string& test_case_file_name);
16 void AddResourceForLayoutTest(const FilePath& parent_dir,
17 const FilePath& resource_name);
18
19 private:
20 void WriteModifiedFile(const std::string& test_case_file_name,
21 GURL* test_url);
jam 2012/03/16 21:42:11 nit: we usually separate the methods and variables
dgrogan 2012/03/16 22:18:35 Done.
22 FilePath our_original_layout_test_dir_;
23 FilePath original_relative_path_;
24 FilePath our_layout_test_temp_dir_;
25 ScopedTempDir scoped_temp_dir_;
jam 2012/03/16 21:42:11 nit DISALLOW_COPY_...
dgrogan 2012/03/16 22:18:35 Done.
26 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698