Run IDB layout test suite as browser tests instead of ui tests

* We no longer run into the cookie size limit and can "run ALL the tests!"
* Browser tests are supposedly faster than ui tests.

BUG=118499
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128362

[dgrogan, 2012-03-16 20:42:08]

John, could you review this?

Hopefully this will be redundant when Jochen gets content_shell working with
layout tests, but we don't want to be gated on that.

Also, how does the test sharding work?  If we add a single
IN_PROC_BROWSER_TEST_F for each layout test file, could they be run in parallel?
 Or will all the IN_PROC_BROWSER_TEST_Fs in IndexedDBLayoutTest be run serially?

[jam, 2012-03-16 21:42:06]

this is great, thanks for doing this. it would be awesome if we can convert all
of the other ones in ui_tests to browser_tests.

On 2012/03/16 20:42:08, dgrogan wrote:
> John, could you review this?
> 
> Hopefully this will be redundant when Jochen gets content_shell working with
> layout tests, but we don't want to be gated on that.
> 
> Also, how does the test sharding work?  If we add a single
> IN_PROC_BROWSER_TEST_F for each layout test file, could they be run in
parallel?

right. i think how you have it is good enough, since the other cores are running
other tests anyways.

>  Or will all the IN_PROC_BROWSER_TEST_Fs in IndexedDBLayoutTest be run
serially?

[jam, 2012-03-16 21:42:11]

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
File content/browser/in_process_webkit/layout_browsertest.cc (right):

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
this file (and the .h) should be in content/test

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.cc:15: #include
"content/browser/in_process_webkit/layout_browsertest.h"
nit: this should be first

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
File content/browser/in_process_webkit/layout_browsertest.h (right):

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:11:
InProcessBrowserLayoutTest(const FilePath relative_layout_test_path);
nit: explicit

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:21: GURL* test_url);
nit: we usually separate the methods and variables by a blank line

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:25: ScopedTempDir
scoped_temp_dir_;
nit DISALLOW_COPY_...

[dgrogan, 2012-03-16 22:18:35]

Ok, thanks for the info!

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
File content/browser/in_process_webkit/layout_browsertest.cc (right):

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2012/03/16 21:42:11, John Abd-El-Malek wrote:
> this file (and the .h) should be in content/test

Done.

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.cc:15: #include
"content/browser/in_process_webkit/layout_browsertest.h"
On 2012/03/16 21:42:11, John Abd-El-Malek wrote:
> nit: this should be first

Done.

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
File content/browser/in_process_webkit/layout_browsertest.h (right):

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:11:
InProcessBrowserLayoutTest(const FilePath relative_layout_test_path);
On 2012/03/16 21:42:11, John Abd-El-Malek wrote:
> nit: explicit

Done.

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:21: GURL* test_url);
On 2012/03/16 21:42:11, John Abd-El-Malek wrote:
> nit: we usually separate the methods and variables by a blank line

Done.

http://codereview.chromium.org/9693065/diff/19001/content/browser/in_process_...
content/browser/in_process_webkit/layout_browsertest.h:25: ScopedTempDir
scoped_temp_dir_;
On 2012/03/16 21:42:11, John Abd-El-Malek wrote:
> nit DISALLOW_COPY_...

Done.

[jam, 2012-03-19 16:17:07]

lgtm

[commit-bot: I haz the power, 2012-03-19 16:18:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9693065/18011

[commit-bot: I haz the power, 2012-03-19 17:27:44]

Try job failure for 9693065-18011 (retry) on linux_rel for steps "browser_tests,
check_deps".
It's a second try, previously, steps "browser_tests, check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[dgrogan, 2012-03-19 20:08:15]

John,

I moved content/test/layout_browsertest.* to chrome/test/base.  Though of course
suboptimal, is that ok?

[jam, 2012-03-19 22:36:58]

On 2012/03/19 20:08:15, dgrogan wrote:
> John,
> 
> I moved content/test/layout_browsertest.* to chrome/test/base.  Though of
course
> suboptimal, is that ok?

please keep it in content/test. Otherwise more chrome includes will leak in and
it'll make it harder when we have content_browsertests.

you can add a DEPS exception in content/test for browser.h just like the one we
have in content/browser/DEPS

[dgrogan, 2012-03-20 00:40:46]

chrome/common/chrome_paths.h for chrome::DIR_LAYOUT_TESTS is also used.  Should
I move DIR_LAYOUT_TESTS to content/public/common/content_paths.h?

[jam, 2012-03-21 04:28:32]

On 2012/03/20 00:40:46, dgrogan wrote:
> chrome/common/chrome_paths.h for chrome::DIR_LAYOUT_TESTS is also used. 
Should
> I move DIR_LAYOUT_TESTS to content/public/common/content_paths.h?

sorry for the delay, just saw this (been distracted by a number of issues)

yes please do this. you'll want to make sure that the DEPS which checks out the
layout tests puts them under content instead of chrome

[dgrogan, 2012-03-22 22:18:56]

jam@, this was synced past moving DIR_LAYOUT_TESTS from chrome to content, not
sure if you want to re-look...

[jam, 2012-03-22 22:27:41]

slgtm, thanks

[commit-bot: I haz the power, 2012-03-22 22:30:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9693065/44002

[commit-bot: I haz the power, 2012-03-23 01:18:50]

Change committed as 128362