mac: Don't use kWebURLsWithTitlesPboardType from third_party/mozilla

mac: Don't use kWebURLsWithTitlesPboardType from third_party/mozilla

It's a hidden symbol in content when doing a components build. Since the string
needs to match what Safari uses anyway, it's unlikely to change: Just hardcode
it in url_drop_target.mm.

While here, fix a possible ODR violation in
bookmark_pasteboard_helper_mac.mm

BUG=90078
TEST=none
TBR=sky

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126332

[Nico, 2012-03-12 23:15:31]

This is currently the last non-gyp code change needed to make the mac components
build work, at least in Release builds.

[Mark Mentovai, 2012-03-12 23:24:12]

Wait.

Did you really mean to have two definitions of kCrWebURLsWithTitlesPboardType?

[Nico, 2012-03-12 23:27:23]

Yes. They're both local to their translation unit (at least that's my intent).

[Mark Mentovai, 2012-03-12 23:37:35]

LGTM otherwise

http://codereview.chromium.org/9692020/diff/4001/chrome/browser/ui/cocoa/url_...
File chrome/browser/ui/cocoa/url_drop_target.mm (right):

http://codereview.chromium.org/9692020/diff/4001/chrome/browser/ui/cocoa/url_...
chrome/browser/ui/cocoa/url_drop_target.mm:14: NSString* const
kCrWebURLsWithTitlesPboardType =
If this only needs to be local to its translation unit, put it into an anonymous
namespace. I know that the language doesn’t require it since the pointer is
const, but it makes your intent a bit more clear.

[Nico, 2012-03-12 23:43:39]

Thanks!

http://codereview.chromium.org/9692020/diff/4001/chrome/browser/ui/cocoa/url_...
File chrome/browser/ui/cocoa/url_drop_target.mm (right):

http://codereview.chromium.org/9692020/diff/4001/chrome/browser/ui/cocoa/url_...
chrome/browser/ui/cocoa/url_drop_target.mm:14: NSString* const
kCrWebURLsWithTitlesPboardType =
On 2012/03/12 23:37:35, Mark Mentovai wrote:
> If this only needs to be local to its translation unit, put it into an
anonymous
> namespace. I know that the language doesn’t require it since the pointer is
> const, but it makes your intent a bit more clear.

Done.

[commit-bot: I haz the power, 2012-03-12 23:46:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9692020/5001

[commit-bot: I haz the power, 2012-03-12 23:46:33]

Presubmit check for 9692020-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/bookmarks

Presubmit checks took 1.1s to calculate.

[Nico, 2012-03-13 02:03:46]

sky: OWNERS

[commit-bot: I haz the power, 2012-03-13 02:04:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9692020/5001

[commit-bot: I haz the power, 2012-03-13 04:47:19]

Change committed as 126332