mac: Don't use kWebURLsWithTitlesPboardType from third_party/mozilla

chrome/browser/ui/cocoa/url_drop_target.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/url_drop_target.h"
 
 #include "base/basictypes.h"
 #include "chrome/browser/ui/cocoa/drag_util.h"
 #include "googleurl/src/gurl.h"
 #import "third_party/mozilla/NSPasteboard+Utils.h"
 
+// Mac WebKit uses this type, declared in
+// WebKit/mac/History/WebURLsWithTitles.h.
+NSString* const kCrWebURLsWithTitlesPboardType =

[Mark Mentovai, 2012/03/12 23:37:35]

If this only needs to be local to its translation unit, put it into an anonymous
namespace. I know that the language doesn’t require it since the pointer is
const, but it makes your intent a bit more clear.

[Nico, 2012/03/12 23:43:39]

Done.

+    @"WebURLsWithTitlesPboardType";
+
 @interface URLDropTargetHandler(Private)
 
 // Gets the appropriate drag operation given the |NSDraggingInfo|.
 - (NSDragOperation)getDragOperation:(id<NSDraggingInfo>)sender;
 
 // Tell the window controller to hide the drop indicator.
 - (void)hideIndicator;
 
 @end  // @interface URLDropTargetHandler(Private)
 
 @implementation URLDropTargetHandler
 
 + (NSArray*)handledDragTypes {
-  return [NSArray arrayWithObjects:kWebURLsWithTitlesPboardType,
+  return [NSArray arrayWithObjects:kCrWebURLsWithTitlesPboardType,
                                    NSURLPboardType,
                                    NSStringPboardType,
                                    NSFilenamesPboardType,
                                    nil];
 }
 
 - (id)initWithView:(NSView<URLDropTarget>*)view {
   if ((self = [super init])) {
     view_ = view;
     [view_ registerForDraggedTypes:[URLDropTargetHandler handledDragTypes]];
@@ skipping 81 matching lines @@
 
   // Only allow the copy operation.
   return [sender draggingSourceOperationMask] & NSDragOperationCopy;
 }
 
 - (void)hideIndicator {
   [[view_ urlDropController] hideDropURLsIndicatorInView:view_];
 }
 
 @end  // @implementation URLDropTargetHandler(Private)