Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 9691038: Ensure there is a smi check of the receiver for global load and call ICs. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Ensure there is a smi check of the receiver for global load and call ICs. There was a comment that, for such ICs specialized to the global object, they were always contextual loads. This is very brittle. It is a micro-optimization that relies too much on the way that things happen to work today. Instead, never omit the smi check because it's safer. R=vegorov@chromium.org BUG=117794 TEST=regress-117794.js Committed: https://code.google.com/p/v8/source/detail?r=11022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -54 lines) Patch
M src/arm/stub-cache-arm.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +2 lines, -13 lines 0 comments Download
A test/mjsunit/regress/regress-117794.js View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 9 months ago (2012-03-13 10:44:26 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-13 11:37:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698