Issue 9691029: Make tools/test.py work on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9691029: Make tools/test.py work on Windows (Closed)

Created:
8 years, 9 months ago by piscisaureus

Modified:
8 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev, Jakob Kummerow

Visibility:
Public.

Description

Make tools/test.py work on Windows It adds too many quotes around shell commands.

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

I don't see why this change is necessary. The test script runs fine with Python ...

8 years, 9 months ago (2012-03-13 15:57:00 UTC) #1

piscisaureus

On 2012/03/13 15:57:00, Yang wrote: > I don't see why this change is necessary. The ...

8 years, 9 months ago (2012-03-13 16:03:10 UTC) #2

Yang

8 years, 9 months ago (2012-03-13 16:57:28 UTC) #3

On 2012/03/13 16:03:10, piscisaureus wrote:
> On 2012/03/13 15:57:00, Yang wrote:
> > I don't see why this change is necessary. The test script runs fine with
> Python
> > 2.6 on Windows for me.
> 
> I am using python 2.7 and it treats the entire command line as the binary to
be
> executes, e.g. it starts looking for "scons mode=debug" instead of "scons".

I can indeed reproduce this for python 2.7. LGTM and landing. Thanks for the
contribution!

Expand Messages | Collapse Messages