Add comments and fix a potential leak in LaunchProcess.

Add comments and fix a potential leak in LaunchProcess.

I found a need to look at the implementation to confirm that process_handle would never be assigned to if the call failed. So I added a comment for future readers.

While doing so, I found an edge case where I think the process handle could be leaked.

BUG=None
TEST=Ask a random developer whether they must check process_handle if LaunchProcess returns false. If they look at process_util_*.cc, fail.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126890

[erikwright (departed), 2012-03-13 20:42:14]

phajdan.jr because you originally added this job_handle stuff.

[willchan no longer on Chromium, 2012-03-13 21:13:56]

I think this code is right, but I'm not a Windows expert (although I know you
are). Let me replace myself with Brett.

[brettw, 2012-03-13 21:28:28]

lgtm

[Paweł Hajdan Jr., 2012-03-14 11:10:34]

LGTM

[commit-bot: I haz the power, 2012-03-14 11:12:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9689081/1

[commit-bot: I haz the power, 2012-03-14 13:49:31]

Try job failure for 9689081-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-15 01:47:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9689081/10019

[commit-bot: I haz the power, 2012-03-15 03:54:07]

Try job failure for 9689081-10019 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-03-15 10:45:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/9689081/10019

[commit-bot: I haz the power, 2012-03-15 12:40:08]

Change committed as 126890