Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3297)

Unified Diff: base/process_util_win.cc

Issue 9689081: Add comments and fix a potential leak in LaunchProcess. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing matching call to CloseHandle(hThread) Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_win.cc
diff --git a/base/process_util_win.cc b/base/process_util_win.cc
index d640d683e3a5b805f7d2fbedf573a35a3bcfb8b1..ab60ce85bf047b83f484376cd00dacd52e417664 100644
--- a/base/process_util_win.cc
+++ b/base/process_util_win.cc
@@ -349,6 +349,8 @@ bool LaunchProcess(const string16& cmdline,
process_info.hProcess)) {
DLOG(ERROR) << "Could not AssignProcessToObject.";
KillProcess(process_info.hProcess, kProcessKilledExitCode, true);
+ CloseHandle(process_info.hProcess);
+ CloseHandle(process_info.hThread);
return false;
}
« no previous file with comments | « base/process_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698