Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9689054: Generate documentation for experimental Font Settings Extension API. (Closed)

Created:
8 years, 9 months ago by falken
Modified:
8 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Generate documentation for experimental Font Settings Extension API. It seems it needed to be added to api_page_generator.js. Also, renamed experimental.fonts.json to experimental.fontSettings.json for consistency. BUG=114148 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126853

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -127 lines) Patch
M chrome/common/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/api/experimental.fontSettings.json View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/experimental.fonts.json View 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/experimental.fontSettings.html View 2 chunks +583 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
8 years, 9 months ago (2012-03-13 08:10:01 UTC) #1
falken
Hi Matt, Could you review this please?
8 years, 9 months ago (2012-03-14 23:33:03 UTC) #2
Matt Perry
lgtm
8 years, 9 months ago (2012-03-14 23:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/9689054/3001
8 years, 9 months ago (2012-03-15 00:13:53 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 03:07:21 UTC) #5
Try job failure for 9689054-3001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698