Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 9689027: MonitorManager to manage multiple monitors. (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 8 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

MonitorManager to manage multiple monitors. * Changed related classes (ScreenAura and layout managers) to use MonitorManager to retrieve monitor information. This will be used to show a message window on another monitor in fullscreen. * SingleMonitorManager for testing. I'll add MonitorManagerX that supports multimonitor under x11. * ScreenAura's CursorPosition methods are unchanged because this doesn't have to be changed for m19. BUG=115510 TEST=tbd

Patch Set 1 #

Patch Set 2 : move to env #

Patch Set 3 : cleanup #

Patch Set 4 : . #

Patch Set 5 : added missing file #

Patch Set 6 : . #

Patch Set 7 : crash fix #

Total comments: 2

Patch Set 8 : updated comment #

Patch Set 9 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -74 lines) Patch
M ash/screen_ash.h View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -13 lines 0 comments Download
M ash/screen_ash.cc View 1 2 3 4 5 6 7 8 3 chunks +17 lines, -18 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -5 lines 0 comments Download
M ash/shell_observer.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 1 2 3 4 5 6 7 8 5 chunks +17 lines, -8 lines 0 comments Download
M ash/wm/toplevel_layout_manager_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 2 3 4 5 6 7 8 3 chunks +10 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/env.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
A ui/aura/monitor.h View 1 2 3 4 5 6 7 1 chunk +48 lines, -0 lines 0 comments Download
A ui/aura/monitor.cc View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager.h View 1 2 3 4 5 6 7 8 1 chunk +50 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager.cc View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A ui/aura/monitor_manager_x11.cc View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 9 months ago (2012-03-12 21:53:59 UTC) #1
oshima
8 years, 9 months ago (2012-03-12 21:54:08 UTC) #2
Ben Goodger (Google)
http://codereview.chromium.org/9689027/diff/79/ui/aura/monitor.h File ui/aura/monitor.h (right): http://codereview.chromium.org/9689027/diff/79/ui/aura/monitor.h#newcode20 ui/aura/monitor.h:20: // Set/gets monitor's bounds in screen's coordinates. what does ...
8 years, 9 months ago (2012-03-13 19:28:12 UTC) #3
oshima
http://codereview.chromium.org/9689027/diff/79/ui/aura/monitor.h File ui/aura/monitor.h (right): http://codereview.chromium.org/9689027/diff/79/ui/aura/monitor.h#newcode20 ui/aura/monitor.h:20: // Set/gets monitor's bounds in screen's coordinates. On 2012/03/13 ...
8 years, 9 months ago (2012-03-13 20:06:37 UTC) #4
Ben Goodger (Google)
Can you clarify (in the code related to aura::Monitor) what the relationship between aura::Monitor and ...
8 years, 9 months ago (2012-03-13 20:47:04 UTC) #5
Ben Goodger (Google)
8 years, 9 months ago (2012-03-13 21:04:39 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698