Adds saner behavior for git try -t foo to not fail in a inexplicable way. Enforces that each builde…

Adds saner behavior for git try -t foo to not fail in a inexplicable way.
Enforces that each builder and builder:test association must be in its own list item in PRESUBMIT.py/GetPreferredTrySlaves().

If a user run git try -t foo, trychange.py will now take the list of all the
slaves, will skip any :compile builder, and apply the test filter to them.

Currently, git try -t foo on a chromium checkout throws an exception because of
PRESUBMIT.py files containing test specification.

R=petermayo@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125975

[Peter Mayo, 2012-03-10 00:30:13]

lgtm

https://chromiumcodereview.appspot.com/9664015/diff/1/trychange.py
File trychange.py (right):

https://chromiumcodereview.appspot.com/9664015/diff/1/trychange.py#newcode813
trychange.py:813: # Strip it.
This comment is not clear - the code says skip the bot.  The comment implies
strip the ":compile"

The code seem right for most testfilters, though some might argue that
implicitly keeping a compile target on that bot would be closer to optimal
intent tracking.

[M-A Ruel, 2012-03-10 01:40:44]

https://chromiumcodereview.appspot.com/9664015/diff/1/trychange.py
File trychange.py (right):

https://chromiumcodereview.appspot.com/9664015/diff/1/trychange.py#newcode813
trychange.py:813: # Strip it.
On 2012/03/10 00:30:13, Peter Mayo wrote:
> This comment is not clear - the code says skip the bot.  The comment implies
> strip the ":compile"
> 
> The code seem right for most testfilters, though some might argue that
> implicitly keeping a compile target on that bot would be closer to optimal
> intent tracking.

For now I'll keep it this way but I'll probably revisit soon.

[commit-bot: I haz the power, 2012-03-10 01:40:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9664015/4001

[commit-bot: I haz the power, 2012-03-10 01:47:47]

Change committed as 125975