Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: presubmit_support.py

Issue 9664015: Adds saner behavior for git try -t foo to not fail in a inexplicable way. Enforces that each builde… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: improve comment Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index 5bd049bcda67ece3b827d202a05cc1db379b1171..0b72f4656b72480d28e72283faa7997749a090c5 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -926,6 +926,9 @@ class GetTrySlavesExecuter(object):
if item != item.strip():
raise PresubmitFailure(
'Try slave names cannot start/end with whitespace')
+ if ',' in item:
+ raise PresubmitFailure(
+ 'Do not use \',\' separated builder or test names: %s' % item)
else:
result = []
return result
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698