Refactoring of chrome speech recognition architecture (CL1.3)

content/public/common/speech_recognition_result.h

Index: content/public/common/speech_recognition_result.h
diff --git a/content/public/common/speech_recognition_result.h b/content/public/common/speech_recognition_result.h
index e5efe5ba9a6362305ec38727aa80a3e752b40d51..d7007631d423d8caa8361878f181adbda9c591e1 100644
--- a/content/public/common/speech_recognition_result.h
+++ b/content/public/common/speech_recognition_result.h
@@ -48,8 +48,24 @@ enum SpeechRecognitionErrorCode {
   SPEECH_RECOGNITION_ERROR_BAD_GRAMMAR,
 };
 
+// Error details for the SPEECH_RECOGNITION_ERROR_AUDIO error.
+enum SpeechAudioErrorDetails {
+  AUDIO_ERROR_UNKNOWN = 0,
+  AUDIO_ERROR_NO_MIC,
+  AUDIO_ERROR_MIC_IN_USE
+};
+
+struct CONTENT_EXPORT SpeechRecognitionError {

[jam, 2012/03/22 17:31:08]

please see http://www.chromium.org/developers/content-module/content-api for
conventions for the Content API

in particular, the enum values should be named
SPEECH_AUDIO_ERROR_DETAILS_UNKNOWN.. and the struct below needs to be in its own
file. if you can avoid a cc file without clang errors, that'd be better

+  SpeechRecognitionErrorCode code;
+  int details;
+
+  SpeechRecognitionError();
+  SpeechRecognitionError(SpeechRecognitionErrorCode code_value);
+  SpeechRecognitionError(SpeechRecognitionErrorCode code_val, int details_val);
+};
+
 struct CONTENT_EXPORT SpeechRecognitionResult {
-  SpeechRecognitionErrorCode error;
+  SpeechRecognitionErrorCode error; // TODO(primiano) This is transitional.
   SpeechRecognitionHypothesisArray hypotheses;
 
   SpeechRecognitionResult();