Refactoring of chrome speech recognition architecture (CL1.3)

content/public/common/speech_recognition_result.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_SPEECH_RECOGNITION_RESULT_H_
 #define CONTENT_PUBLIC_COMMON_SPEECH_RECOGNITION_RESULT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 30 matching lines @@
   // There was a network error.
   SPEECH_RECOGNITION_ERROR_NETWORK,
   // No speech heard before timeout.
   SPEECH_RECOGNITION_ERROR_NO_SPEECH,
   // Speech was heard, but could not be interpreted.
   SPEECH_RECOGNITION_ERROR_NO_MATCH,
   // There was an error in the speech recognition grammar.
   SPEECH_RECOGNITION_ERROR_BAD_GRAMMAR,
 };
 
+// Error details for the SPEECH_RECOGNITION_ERROR_AUDIO error.
+enum SpeechAudioErrorDetails {
+  AUDIO_ERROR_UNKNOWN = 0,
+  AUDIO_ERROR_NO_MIC,
+  AUDIO_ERROR_MIC_IN_USE
+};
+
+struct CONTENT_EXPORT SpeechRecognitionError {

[jam, 2012/03/22 17:31:08]

please see http://www.chromium.org/developers/content-module/content-api for
conventions for the Content API

in particular, the enum values should be named
SPEECH_AUDIO_ERROR_DETAILS_UNKNOWN.. and the struct below needs to be in its own
file. if you can avoid a cc file without clang errors, that'd be better

+  SpeechRecognitionErrorCode code;
+  int details;
+
+  SpeechRecognitionError();
+  SpeechRecognitionError(SpeechRecognitionErrorCode code_value);
+  SpeechRecognitionError(SpeechRecognitionErrorCode code_val, int details_val);
+};
+
 struct CONTENT_EXPORT SpeechRecognitionResult {
-  SpeechRecognitionErrorCode error;
+  SpeechRecognitionErrorCode error; // TODO(primiano) This is transitional.
   SpeechRecognitionHypothesisArray hypotheses;
 
   SpeechRecognitionResult();
   ~SpeechRecognitionResult();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_SPEECH_RECOGNITION_RESULT_H_