Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5042)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 9662055: Test for --nacl-gdb functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Windows XP compatibility Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/nacl_process_host.cc
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.cc (revision 126069)
+++ chrome/browser/nacl_host/nacl_process_host.cc (working copy)
@@ -279,7 +279,12 @@
}
#if defined(OS_WIN)
if (RunningOnWOW64()) {
- NaClBrokerService::GetInstance()->OnLoaderDied();
+ // If nacl-gdb switch is not empty, NaCl loader has been launched
Mark Seaborn 2012/03/14 23:33:14 "the nacl-gdb switch" "the NaCl loader"
halyavin 2012/03/15 15:31:36 Done.
+ // without broker and so we shouldn't inform broker about its termination.
Mark Seaborn 2012/03/14 23:33:14 "the broker"
halyavin 2012/03/15 15:31:36 Done.
+ if (CommandLine::ForCurrentProcess()->GetSwitchValuePath(
+ switches::kNaClGdb).empty()) {
+ NaClBrokerService::GetInstance()->OnLoaderDied();
+ }
} else {
debug_context_->SetChildProcessHost(NULL);
}
@@ -599,7 +604,7 @@
if (base::OpenProcessHandleWithAccess(
peer_pid,
base::kProcessAccessDuplicateHandle |
- base::kProcessAccessQueryLimitedInfomation |
+ base::kProcessAccessQueryInformation |
Mark Seaborn 2012/03/14 23:33:14 Please document this change in the commit message.
halyavin 2012/03/15 15:31:36 Done.
base::kProcessAccessWaitForTermination,
&process)) {
process_->SetHandle(process);
« no previous file with comments | « no previous file | chrome/browser/nacl_host/test/mock_nacl_gdb.h » ('j') | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698