Test for --nacl-gdb functionality.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 261 matching lines @@
   }
 
   if (reply_msg_) {
     // The process failed to launch for some reason.
     // Don't keep the renderer hanging.
     reply_msg_->set_reply_error();
     chrome_render_message_filter_->Send(reply_msg_);
   }
 #if defined(OS_WIN)
   if (RunningOnWOW64()) {
-    NaClBrokerService::GetInstance()->OnLoaderDied();
+    // If nacl-gdb switch is not empty, NaCl loader has been launched

[Mark Seaborn, 2012/03/14 23:33:14]

"the nacl-gdb switch"

"the NaCl loader"

[halyavin, 2012/03/15 15:31:36]

Done.

+    // without broker and so we shouldn't inform broker about its termination.

[Mark Seaborn, 2012/03/14 23:33:14]

"the broker"

[halyavin, 2012/03/15 15:31:36]

Done.

+    if (CommandLine::ForCurrentProcess()->GetSwitchValuePath(
+            switches::kNaClGdb).empty()) {
+      NaClBrokerService::GetInstance()->OnLoaderDied();
+    }
   } else {
     debug_context_->SetChildProcessHost(NULL);
   }
 #endif
 }
 
 // Attempt to ensure the IRT will be available when we need it, but don't wait.
 bool NaClBrowser::EnsureIrtAvailable() {
   if (IrtAvailable())
     return true;
@@ skipping 299 matching lines @@
 void NaClProcessHost::OnChannelConnected(int32 peer_pid) {
   // Set process handle, if it was not set previously.
   // This is needed when NaCl process is launched with nacl-gdb.
   if (process_->GetData().handle == base::kNullProcessHandle) {
     base::ProcessHandle process;
     DCHECK(!CommandLine::ForCurrentProcess()->GetSwitchValuePath(
         switches::kNaClGdb).empty());
     if (base::OpenProcessHandleWithAccess(
             peer_pid,
             base::kProcessAccessDuplicateHandle |
-            base::kProcessAccessQueryLimitedInfomation |
+            base::kProcessAccessQueryInformation |

[Mark Seaborn, 2012/03/14 23:33:14]

Please document this change in the commit message.

[halyavin, 2012/03/15 15:31:36]

Done.

             base::kProcessAccessWaitForTermination,
             &process)) {
       process_->SetHandle(process);
       OnProcessLaunched();
     } else {
       LOG(ERROR) << "Failed to get process handle";
     }
   }
   if (!IsHardwareExceptionHandlingEnabled()) {
     return;
@@ skipping 183 matching lines @@
   process_->Send(new NaClProcessMsg_Start(handles_for_sel_ldr));
 #endif
 
   internal_->sockets_for_sel_ldr.clear();
 }
 
 bool NaClProcessHost::OnMessageReceived(const IPC::Message& msg) {
   NOTREACHED() << "Invalid message with type = " << msg.type();
   return false;
 }