Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: runtime/bin/main.cc

Issue 9657001: Start using Dart_PropagateError in the runtime/bin directory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/main.cc
===================================================================
--- runtime/bin/main.cc (revision 5191)
+++ runtime/bin/main.cc (working copy)
@@ -244,7 +244,7 @@
const char* url_string = NULL;
Dart_Handle result = Dart_StringToCString(url, &url_string);
if (Dart_IsError(result)) {
- return Dart_Error("accessing url characters failed");
+ return result;
}
bool is_dart_scheme_url = DartUtils::IsDartSchemeURL(url_string);
bool is_dart_extension_url = DartUtils::IsDartExtensionSchemeURL(url_string);
@@ -258,7 +258,7 @@
Dart_Handle builtin_lib = Builtin::LoadLibrary(Builtin::kBuiltinLibrary);
Dart_Handle library_url = Dart_LibraryUrl(library);
if (Dart_IsError(library_url)) {
- return Dart_Error("accessing library url failed");
+ return library_url;
}
Dart_Handle dart_args[2];
dart_args[0] = library_url;
@@ -329,7 +329,7 @@
3, dart_args);
if (Dart_IsError(script_url)) {
fprintf(stderr, "%s", Dart_GetError(script_url));
- return false;
+ return script_url;
}
if (original_script_url == NULL) {
const char* script_url_cstr;

Powered by Google App Engine
This is Rietveld 408576698