runtime/bin/gen_snapshot.cc - Issue 9657001: Start using Dart_PropagateError in the runtime/bin directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 9657001: Start using Dart_PropagateError in the runtime/bin directory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/gen_snapshot.cc

===================================================================

--- runtime/bin/gen_snapshot.cc (revision 5191)

+++ runtime/bin/gen_snapshot.cc (working copy)

@@ -127,7 +127,7 @@

const char* url_string = NULL;

Dart_Handle result = Dart_StringToCString(url, &url_string);

if (Dart_IsError(result)) {

- return Dart_Error("accessing url characters failed");

+ return result;

}

// If the URL starts with "dart:" then it is handled specially.

@@ -175,7 +175,7 @@

const char* url_string = NULL;

Dart_Handle result = Dart_StringToCString(url, &url_string);

if (Dart_IsError(result)) {

- return Dart_Error("accessing url characters failed");

+ return result;

}

// We only support canonicalization of "dart:".

if (DartUtils::IsDartSchemeURL(url_string)) {

« runtime/bin/file.cc ('K') | « runtime/bin/file.cc ('k') | runtime/bin/main.cc » ('j') | runtime/bin/process.cc » ('J')