Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: PRESUBMIT.py

Issue 9655005: depot_tools doesn't support python 2.5 anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3ae6bcb0f65eb0d8f3d539d17cfbcd5e04186a02..39794a818fa0ac223917fc4735e0f65f188947ed 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -11,18 +11,6 @@ details on the presubmit API built into depot_tools.
def CommonChecks(input_api, output_api, tests_to_black_list):
results = []
- import sys
- if not sys.version.startswith('2.5'):
- # Depot_tools has the particularity that it needs to be tested on python
- # 2.5. But we don't want the presubmit check to fail if it is not installed.
- results.append(output_api.PresubmitNotifyResult(
- 'You should install python 2.5 and run ln -s $(which python2.5) python.'
- '\n'
- 'A great place to put this symlink is in depot_tools.\n'
- 'Otherwise, you break depot_tools on python 2.5, you get to keep the '
- 'pieces.'))
-
-
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
black_list = list(input_api.DEFAULT_BLACK_LIST) + [
r'^cpplint\.py$',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698