Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: PRESUBMIT.py

Issue 9655005: depot_tools doesn't support python 2.5 anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for depot tools. 5 """Top-level presubmit script for depot tools.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api, tests_to_black_list): 12 def CommonChecks(input_api, output_api, tests_to_black_list):
13 results = [] 13 results = []
14 import sys
15 if not sys.version.startswith('2.5'):
16 # Depot_tools has the particularity that it needs to be tested on python
17 # 2.5. But we don't want the presubmit check to fail if it is not installed.
18 results.append(output_api.PresubmitNotifyResult(
19 'You should install python 2.5 and run ln -s $(which python2.5) python.'
20 '\n'
21 'A great place to put this symlink is in depot_tools.\n'
22 'Otherwise, you break depot_tools on python 2.5, you get to keep the '
23 'pieces.'))
24
25
26 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) 14 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
27 black_list = list(input_api.DEFAULT_BLACK_LIST) + [ 15 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
28 r'^cpplint\.py$', 16 r'^cpplint\.py$',
29 r'^cpplint_chromium\.py$', 17 r'^cpplint_chromium\.py$',
30 r'^python_bin[\/\\].+', 18 r'^python_bin[\/\\].+',
31 r'^site-packages-py[0-9]\.[0-9][\/\\].+', 19 r'^site-packages-py[0-9]\.[0-9][\/\\].+',
32 r'^svn_bin[\/\\].+', 20 r'^svn_bin[\/\\].+',
33 r'^testing_support[\/\\]_rietveld[\/\\].+'] 21 r'^testing_support[\/\\]_rietveld[\/\\].+']
34 results.extend(input_api.canned_checks.RunPylint( 22 results.extend(input_api.canned_checks.RunPylint(
35 input_api, 23 input_api,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 96
109 97
110 def CheckChangeOnCommit(input_api, output_api): 98 def CheckChangeOnCommit(input_api, output_api):
111 output = [] 99 output = []
112 output.extend(CommonChecks(input_api, output_api, [])) 100 output.extend(CommonChecks(input_api, output_api, []))
113 output.extend(input_api.canned_checks.CheckDoNotSubmit( 101 output.extend(input_api.canned_checks.CheckDoNotSubmit(
114 input_api, 102 input_api,
115 output_api)) 103 output_api))
116 output.extend(RunGitClTests(input_api, output_api)) 104 output.extend(RunGitClTests(input_api, output_api))
117 return output 105 return output
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698